Merge commit '6bd7fac875d9e9009915053d8a590abb372c5679' into feature/livekit-upgrade-1.13.1

livekit-server/pkg/utils/incrementaldispatcher.go

@@ -43,8 +43,8 @@ func (d *IncrementalDispatcher[T]) Add(item T) {
 	}
 	d.lock.Lock()
 	d.items = append(d.items, item)
-	d.lock.Unlock()
 	d.cond.Broadcast()
+	d.lock.Unlock()
 }
 
 func (d *IncrementalDispatcher[T]) Done() {

livekit-server/pkg/utils/incrementaldispatcher_test.go

@@ -53,7 +53,7 @@ func TestConcurrentConsumption(t *testing.T) {
 	sums := make([]atomic.Int32, numConsumers)
 	var wg sync.WaitGroup
 
-	for i := 0; i < numConsumers; i++ {
+	for i := range numConsumers {
 		wg.Add(1)
 		i := i
 		go func() {
@@ -66,12 +66,12 @@ func TestConcurrentConsumption(t *testing.T) {
 
 	// Add items
 	expectedSum := 0
-	for i := 0; i < 20; i++ {
+	for i := range 20 {
 		expectedSum += i
 		producer.Add(i)
 	}
 
-	for i := 0; i < numConsumers; i++ {
+	for i := range numConsumers {
 		testutils.WithTimeout(t, func() string {
 			if sums[i].Load() != int32(expectedSum) {
 				return fmt.Sprintf("consumer %d did not consume all the items. expected %d, actual: %d",
@@ -91,7 +91,7 @@ func TestConcurrentConsumption(t *testing.T) {
 	producer.Done()
 	wg.Wait()
 
-	for i := 0; i < numConsumers; i++ {
+	for i := range numConsumers {
 		require.Equal(t, int32(expectedSum), sums[i].Load(), "consumer %d did not match", i)
 	}
 }

livekit-server/pkg/utils/math.go

@@ -14,19 +14,18 @@
 
 package utils
 
-import "sort"
+import "slices"
 
-// MedianFloat32 gets median value for an array of float32
-func MedianFloat32(input []float32) float32 {
+// Median gets median value for an array
+func Median[T float32](input []T) T {
 	num := len(input)
-	if num == 0 {
+	switch num {
+	case 0:
 		return 0
-	} else if num == 1 {
+	case 1:
 		return input[0]
 	}
-	sort.Slice(input, func(i, j int) bool {
-		return input[i] < input[j]
-	})
+	slices.Sort(input)
 	if num%2 != 0 {
 		return input[num/2]
 	}
@@ -34,3 +33,16 @@ func MedianFloat32(input []float32) float32 {
 	right := input[num/2]
 	return (left + right) / 2
 }
+
+func Signum[T int | int8 | int16 | int32 | int64 | float32 | float64](val T) int {
+	switch {
+	case val < 0:
+		return -1
+
+	case val > 0:
+		return 1
+
+	default:
+		return 0
+	}
+}

livekit-server/pkg/utils/slice.go

@@ -0,0 +1,11 @@
+package utils
+
+import (
+	"cmp"
+	"slices"
+)
+
+func DedupeSlice[T cmp.Ordered](s []T) []T {
+	slices.Sort(s)
+	return slices.Compact(s)
+}